-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MoNuSAC Dataset #158
Add MoNuSAC Dataset #158
Conversation
There's an error thrown by an input image (
whereas, if I request for a patch shape of (128. 128), it works just fine. What do you think about this @constantinpape? (I think the issue is that the paddding implementation for multi-channel inputs is missing) |
@constantinpape The padding for images with raw and label channels has been taken care of now. Let me know how this looks now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comments I left in the code: this data is saved as RGBA. That doesn't make sense, the alpha channel (A) does not contain any information and we should get rid of it.
Okay. So for this, what would you recommend? (to manually remove the alpha channels from the tif images? ~ using a functionality on top) (UPDATE: I implemented a funcitonality which takes care of this in the recent commit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, you should just change how the RGBA data is converted.
(WIP) Haven't been tested, as the
generate_labeled_array
depends on the MoNuSeg PR (will test and put to review once this works)